Subject: Re: basesrc/lib/libc/arch/powerpc/gen/sigsetjmp.S,v
To: Bill Studenmund <wrstuden@netbsd.org>
From: Allen Briggs <briggs@wasabisystems.com>
List: port-macppc
Date: 08/08/2002 22:48:14
On Thu, Aug 08, 2002 at 07:40:39PM -0700, Bill Studenmund wrote:
> On Fri, 9 Aug 2002, Makoto Fujiwara wrote:
>
> > Is this kind of typo ?
> >
> > Index: sigsetjmp.S
> > ===================================================================
> > RCS file: /cvsroot/basesrc/lib/libc/arch/powerpc/gen/sigsetjmp.S,v
> > retrieving revision 1.5
> > diff -u -r1.5 sigsetjmp.S
> > --- sigsetjmp.S 2002/07/30 06:07:58 1.5
> > +++ sigsetjmp.S 2002/08/08 23:54:24
> > @@ -36,7 +36,7 @@
> > mr %r1,%r10
> > or. %r7,%r7,%r7
> > beq 1f
> > - mr %r4,8
> > + mr %r4,%r8
> > li %r3,3 # SIG_SETMASK
> > li %r0,SYS_compat_13_sigprocmask13
> > sc # assume no error XXX
>
> Not that I know of. mr moves from register to register, so '8' was
> shorthand for '%r8' anyway.
It should be fixed, though, since one good reason for register prefixes
is to avoid this ambiguity. :-)
Thank you for the sharp eyes, Fujiwara-san. I have committed the
change.
-allen
--
Allen Briggs briggs@wasabisystems.com
http://www.wasabisystems.com/ Quality NetBSD CDs, Sales, Support, Service
NetBSD development for Alpha, ARM, M68K, MIPS, PowerPC, SuperH, XScale, etc...