Subject: Re: sysinst bug and errors
To: Dave Huang <khym@azeotrope.org>
From: Scott Reynolds <scottr@clank.org>
List: port-mac68k
Date: 09/05/2002 22:04:55
On Tue, 3 Sep 2002, Dave Huang wrote:
> I do wonder about this bit of code around line 581 of locore.s though:
> [...]
> CVS says:
>
> revision 1.80
> date: 1997/06/29 06:07:39; author: scottr; state: Exp; lines: +590 -745
> Get several cleanup chores out of the way. The code is functionally
> identical to the previous incarnation.
>
> However, a diff between 1.79 and 1.80 shows:
> - cmpl #FPU_68040,_fputype | 68040? (see fpu.c)
> - jne Lfp_unsupp | no, treat as illinst
> + cmpl #FPU_68040,_C_LABEL(fputype) | 68040 FPU?
> + jne _C_LABEL(illinst) | no, treat as illinst
>
> which doesn't look like a functionally identical change to me :)
Actually, in context I think it ends up being functionally identical. It's
been over 5 years since this commit so I don't recall the full analysis.
However, note that this change appeared in NetBSD 1.3 and is a part of
several different m68k platforms' releases. This problem seems to be much
more recent.
--scott