Re: Incomplete bus.h

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

martin@ wrote:

> Some m68k architectures have an incomplete bus.h header: it does not
> define bus_dma_tag_t and friends. Solution would be to add a
> 
>  #include <m68k/bus_dma.h>
> 
> in there (as for example mac68k already does). This would fix -current
> build failures in if_axe.c.
> 
> Is there any reason not to do this?

I think <m68k/bus_dma.h> should be used for ports
which use arch/m68k/m68k/bus_dma.c implementation.
mac68k actually uses m68k/bus_dma.c for SONIC Ethernet.

To appease unusable USB modules for ancient ports,
it's less confusing to add dummy bus_dma typedef's
like arch/mmeye/include/bus_defs.h.

(should we have MI bus_dma_dummy.h or so?)
---
Izumi Tsutsui