Re: libm compilation failing in -current

[Frank Wille <frank%phoenix.owl.de@localhost>]

On Tue, 5 Jan 2010 23:27:34 +0000 (UTC)
christos%astron.com@localhost (Christos Zoulas) wrote:

> > [...]
> > ENTRY($NAME)
> > #ifdef __SVR4_ABI__
> >-   jbra _C_LABEL(__fplsp060_$OFFS)
> >+   bral _C_LABEL(__fplsp060_$OFFS)@PLTPC
> > #else
> >    movel %sp@(4),%sp@-
> >-   jbsr _C_LABEL(__fplsp060_$OFFS)
> >+   bsrl _C_LABEL(__fplsp060_$OFFS)@PLTPC
> >    fmoves %fp0,%sp@
> >    movel %sp@+,%d0
> >    rts
> 
> Looks good, but you should probably use the PIC_PLT() macro from asm.h

Yes, you're right! I nearly forgot that the same source is used for
building the static library as well. Thanks.


> if bsrl can handle non-plt jumps; otherwise you need an ifdef I think.

It can. The jbra was already turned into a bral with 32-bit PC-relative
relocation before.


-- 
Frank Wille