Port-i386 archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: x86 pcitag_t change proposal/patch

On Dec 5, 2012, at 2:40 PM, Jonathan A. Kollasch wrote:

> Round 2:
> Use more descriptive pcitag_t structure member names and add comment
> updates.
> I did not change the use of bitfields in pcitag_t because they are not
> used with the hardware.
> <pcitag-diff-1.txt>

I still don't like use of bitfields.  in 99% of the cases the tag will be or'ed 
with the register number and bitfields prevent that.

Home | Main Index | Thread Index | Old Index