Port-i386 archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Workaround for invalid firmware-date values



On 01/17/11 21:58, David Laight wrote:
On Mon, Jan 17, 2011 at 09:30:43PM +0000, Julio Merino wrote:
        unsigned long date;
Is that type a good idea ??
The code that uses it isn't in your diff, but my gut feeling is
it is the wrong type for LP64 systems.
Why (genuine curiosity)? The code uses strtoul to parse 'datestr' into 'date' and it discards "too large" values before casting the value to an int. Seems safe to me.

Home | Main Index | Thread Index | Old Index