Port-i386 archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Merging few files from i386/amd64 into x86

Christoph Egger <Christoph_Egger%gmx.de@localhost> wrote:
> > Concerns:
> >
> > - Any reason why we would want to keep the type size in MD (instead of
> >   abstracting it out, eg. with uintptr_t)?
> Ok with me, but take care about storage of physical addresses: uintptr_t
> is not large enough in respect to 32bit PAE.

For physical address paddr_t is/should be used, not uintptr_t.

> >   By the way: 
> >   http://nxr.netbsd.org/source/xref/sys/arch/i386/include/frame.h#trapframe
> >   Why these and others are not unsigned, eg. uint32_t?
> IMO, this is a bug because this reduces the effective register size to
> 31bits.


Andrew - are we missing something here?

Best regards,

Home | Main Index | Thread Index | Old Index