port-i386: Re: mbr seems to check MBR_MAGIC against wrong location

Subject: Re: mbr seems to check MBR_MAGIC against wrong location
To: Yuichiro Goto <goto@acr.kanazawa-it.ac.jp>
From: David Laight <david@l8s.co.uk>
List: port-i386
Date: 05/06/2005 07:58:40

On Fri, May 06, 2005 at 10:17:11AM +0900, Yuichiro Goto wrote:
> Hi,
> 
> I recently read src/sys/arch/i386/stand/mbr/mbr.S, and I have had a
> question.

Only one...
You get a prize it you manage to squeeze out any more bytes, or add
further (useful) functionality within the available space!
 
> When the mbr code checks extended partition chain, it always checks
> MBR_MAGIC against
> itself, that is LOADADDR + MBR_MAGIC_OFFSET, but not newly loaded
> sector into BOOTADDR. I think
> BOOTADDR + MBR_MAGIC_OFFSET is correct location to check.

One the face of it that does seem correct....

	David

-- 
David Laight: david@l8s.co.uk