Hi! tsutsui-san


From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
Date: Wed, 27 Sep 2006 07:37:00 +0900

> > > Maybe we should move _splnone() from autoconf.c:cpu_configure() to
> > > mips/mips3_clockintr():cpu_initclocks(), but I wonder
> > > we should still enable other interrupts than INT5 in
> > > cpu_configure() or not. (since initclocks() is called
> > > right after cpu_configure() in subr_autoconf.c).

> IMO "_spllower(MIPS_INT_MASK_5)" is enough like arc/autoconf.c does
> for optional statclock(9), and some people also said that we should
> have some comments why we needed such weird spl(9) handling in both
> cpu_configure(9) and cpu_initclocks(9).

I agree.  However the bit MIPS_SR_INT_IE was already set?
I think that here is good because of it. 

  #define _splnoclock()	  _spllower(MIPS_INT_MASK_5 | MIPS_SR_INT_IE)


Thanks,
--
kiyohara