Port-atari archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Floppy image overflow



christos, tsutsui, thank you for your useful comments! I've updated
the patch accordingly:

  http://www.netbsd.org/~rin/atari_floppy_20160208.patch

On 2017/02/07 23:51, Christos Zoulas wrote:
I am not enamored  with more ifdef's but this seems ok to me.

Neither do I :-). In the new version, I've removed most of ifdef's.
Instead, I define flags like needswap or isappleufs as (0), and unused
functions as /* nothing */. The today's compiler is clever enough to
optimize out what we don't need, and we obtain the same (!) results as
before.

On 2017/02/07 23:54, Izumi Tsutsui wrote:
I have a feeling that it would be better to add src/distrib/x_newfs
etc. like src/distrib/x_disklabel and specify it in
distrib/atari/floppies/install/list so that other poor ports
can share them.

I've added src/distrib/x_{fsck_ffs,newfs} and brief instruction there.

Note that the original Makefile in src/sbin/{fsck_ffs,newfs} has been
split into Makefile and Makefile.common, not Makefile.inc as in the
case of x_ifconfig. This is because Makefile.inc conflicts with
bsd.subdir.mk. I will also rename it for x_ifconfig, and do some clean
up after committing the main patch.

Thanks,
rin


Home | Main Index | Thread Index | Old Index