Subject: Re: ttyflags: TIOCSFLAGS on /dev/mdm02: Device not configured
To: None <waldi@moacs.indiv.nl.net>
From: Leo Weppelman <leo@wau.mis.ah.nl>
List: port-atari
Date: 11/28/1995 13:37:00
Hello Michael, Waldi,
> 
> > > > "Device not configured" would still be a somewhat stange error message...)
> > > 
> > > I agree, "Operation not supported" would make more sense.
> > 
> > Should I `send-pr'?
> 
> Theoretically, yes. But this one is in src/sys/arch/atari/dev/zs.c:
I take this as a hint ;-)
But wouldn't EINVAL be the most logical return value?
(Trying to defend guru status ;-) )
> 
> --- zs.c.orig	Thu Nov 16 13:31:39 1995
> +++ zs.c	Tue Nov 28 10:41:42 1995
> @@ -822,11 +822,11 @@
>  		 # defaulting to software flow control.
>  		 */
>  		if(userbits & TIOCFLAG_SOFTCAR && userbits & TIOCFLAG_CLOCAL)
>  			return(EINVAL);
>  		if(userbits & TIOCFLAG_MDMBUF)	/* don't support this (yet?) */
> -			return(ENXIO);
> +			return(ENODEV);
>  
>  		s = splzs();
>  		if((userbits & TIOCFLAG_SOFTCAR)) {
>  			cs->cs_softcar = 1;	/* turn on softcar */
>  			cs->cs_preg[15] &= ~ZSWR15_DCD_IE; /* turn off dcd */
> 
> 
Leo.