Subject: Re: Games/craft 3.5 still won't work :-(
To: None <port-arm32@netbsd.org>
From: Christoph Badura <bad@oreilly.de>
List: port-arm32
Date: 08/04/1999 19:23:59
>On Wed, 4 Aug 1999, Reinoud Zandijk wrote:

>> pkg-maintainer: Well, a lot of the files are compiling OK now, but also
>> `xfile.hc' has to be changed at lines 15-18: the `char's here must also be
                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> `signed char's as they are also compared to EOF....
   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I just noticed this.  Normally it never makes sense to compare chars to EOF
since chars can't hold EOF[*].  You probably want ints.

[*] the only functions which retun EOF are stdio functions and they will
never return a valid char that is indistiguishable from EOF.

-- 
Christoph Badura					www.netbsd.org

	Anything that can be done in O(N) can be done in O(N^2).
	-- Ralf Schuettau (after looking at a particular piece of code)