Subject: Re: etherH in NetBSD-current
To: Stefan Voss <voss@yoda.in-berlin.de>
From: Mark Brinicombe <amb@physig.ph.kcl.ac.uk>
List: port-arm32
Date: 05/09/1997 02:44:06
On Sat, 3 May 1997, Stefan Voss wrote:

> In message <Pine.SGI.3.95.970506141554.10163C-100000@physig4.ph.kcl.ac.uk>
>      Mark Brinicombe wrote: 
> 
> > [...]
> > 
> > I'll fix this in the sources 
> > 
> > It should read
> > 
> > if ((matchpodule(pa, MANUFACTURER_ICUBED, PODULE_ICUBED_ETHERH, -1) == 0) &&
> >    (matchpodule(pa, MANUFACTURER_ICUBED, PODULE_ICUBED_ETHERHFLASH, -1) ==
> >     0))
> >         return(0)
> 
> Shouldn't that be a "logical OR" (||) instead of a "logical AND" (&&)?

matchpodule returns 0 if the match failed so we only want to fail the
probes if both matches failed. If either one matched i.e. non zero then we
do not want to return(0).

Cheers,
				Mark