Re: Configuring the I2C clock on the ODROID C2

[Vincent DEFERT <vincent.defert%posteo.net@localhost>]

Thanks a lot, it's what I was missing.

mesongxbb_clkc.c already contains the appropriate definition:

    MESON_CLK_GATE(MESONGXBB_CLOCK_I2C, "i2c", "clk81", HHI_GCLK_MPEG0, 9),

and fdtbus_clock_get_index(phandle, 0) returned the clock. :)

On 04/10/2022 19:15, Robert Swindells wrote:
> Vincent DEFERT <vincent.defert%posteo.net@localhost> wrote:
> > I'm testing my I2C driver for the ODROID C2 and it fails to get the I2C
> > peripheral clock.
> >
> > In meson-gxbb.dtsi, I have:
> >
> >      &i2c_A {
> >          clocks = <&clkc CLKID_I2C>;
> >      };
> >
> > and CLKID_I2C is defined as 22 in dt-bindings/clock/gxbb-clkc.h.
> > No clock-name is defined for this clock in the DTS.
> The various NetBSD arm clock drivers do not use the device tree to
> work out how to enable clocks for a particular device.
>
> You need to check in mesongxbb_clkc.c to see if the clock you need
> has already got a definition, and if not add it.
>
> The section on "Clock and Reset" in the S905 Datasheet looks detailed
> enough to contain the information needed.
>
> Also, the device tree definition may need to be extended, check whether
> it defines a clocks property for the i2c_A device.