[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: [PATCH] String offset errors on evbarm 8.99 [PR 54159]
>On Thu, Aug 15, 2019 at 10:45:10AM +0200, Martin Husemann wrote:
>> On Thu, Aug 15, 2019 at 10:27:51AM +0200, tlaronde%polynum.com@localhost wrote:
>> > Solution adopted:
>> > The simplest: since the caller of swap_symbol_in() has the
>> > information, I added a supplementary parameter to
>> > swap_symbol_in() to pass the correct symtab_hdr pointer,
>> > modified the calls and added ATTRIBUTE_UNUSED in the
>> > implementations that don't use it.
>> Great job!
>> This should be discussed upstream on the binutils mailing list.
>> There is nothing NetBSD specific in here, isn't it?
>FWIW, I have submitted the patches, updated against binutils current
>release, to upstream with the mention that this was done when tracking
>a NetBSD PR.
I built a full distribution for earmv7hf with your patches and built a
fair number of packages with it and everything seems fine.
Maybe we should just commit your patches to -current then pull them up
to -9 after testing a bit more.
I'm guessing that we wouldn't pull up a new binutils release to -9.
Main Index |
Thread Index |