Re: 2016-11-27-netbsd-raspi-earmv6hf.img (Re: Raspberry Pi update please.)

[Michael Cheponis <michael.cheponis%gmail.com@localhost>]

​​
Thank you, again.  I have been using your work now for many months, it runs
very solidly on my RPi3 -- quite a pleasure.

I have a question about this patch:

diff -u -r1.5 bcm2835_bsc.c
--- bcm2835_bsc.c       24 Jan 2015 00:27:31 -0000      1.5
+++ bcm2835_bsc.c       23 May 2016 05:51:00 -0000
@@ -91,6 +91,9 @@
        if (strcmp(aaa->aaa_name, "bcmbsc") != 0)
                return 0;

+       if (aaa->aaa_addr == BCM2835_BSC0_BASE)
+               return 0;
+
        return 1;
 }


Why not do:

   return aaa->aaa_addr != BCM2835_BSC0_BASE;

or (better):

   return ! ( aaa->aaa_addr == BCM2835_BSC0_BASE );

Maybe the compiler makes the same code in all three cases?


or just maybe the original is just easier to read! ;-)


Thanks,

Mike



On Wed, Nov 23, 2016 at 3:52 AM, Jun Ebihara <jun%soum.co.jp@localhost> wrote:

> I've updated 2016-11-27-netbsd-raspi-earmv6hf.img.gz for RPI.
>
> http://cdn.netbsd.org/pub/NetBSD/misc/jun/raspberry-pi/
> 2016-11-27-earmv6hf/2016-11-27-netbsd-raspi-earmv6hf.img.gz
> http://cdn.netbsd.org/pub/NetBSD/misc/jun/raspberry-pi/
> 2016-11-27-earmv6hf/MD5
>
> Kernel for RPI3:
> http://mail-index.netbsd.org/port-arm/2016/06/16/msg003830.html
> http://cdn.netbsd.org/pub/NetBSD/misc/jun/raspberry-pi/
> 2016-11-27-earmv6hf/RPI3/
>
> If you use un-patched-original kernel.
>  mv /boot/kernel7.img.orignal /boot/kernel7.img
>
> Overview:
>   http://wiki.NetBSD.org/ports/evbarm/raspberry_pi/
>
> dmesg:
>   https://github.com/ebijun/NetBSD/blob/master/dmesg/earmv6hf/RPI
>   https://github.com/ebijun/NetBSD/blob/master/dmesg/earmv6hf/RPI0
>   https://github.com/ebijun/NetBSD/blob/master/dmesg/earmv6hf/RPI2
>   https://github.com/ebijun/NetBSD/blob/master/dmesg/earmv6hf/RPI2-1.2
>   https://github.com/ebijun/NetBSD/blob/master/dmesg/earmv6hf/RPI3
>
> Pre-installed packages:
>  https://github.com/ebijun/NetBSD/blob/master/RPI/RPIimage/pkgsrc/pkginfo
>
> Update:
> - NetBSD-current 7.99.42 evbarm-earmv6hf 201611220640Z rpi.img from nyftp