Re: Porting DTrace to ARM

[Ryota Ozaki <ozaki-r%NetBSD.org@localhost>]

On Thu, Mar 6, 2014 at 5:32 PM, David Laight <david%l8s.co.uk@localhost> wrote:
> On Thu, Mar 06, 2014 at 03:34:18PM +0900, Ryota Ozaki wrote:
>> On Thu, Mar 6, 2014 at 2:21 PM, Masao Uebayashi 
>> <uebayasi%gmail.com@localhost> wrote:
>> > Ah.  I misread that schedstate_percpu uses percpu(9)'s fast path,
>> > which doesn't exist...
>> >
>> > Anyway if it's assumed that cpu is not attached at run-time, assigning
>> > struct cpu_data::void *cpu_dtraceinfo at module attachment would be
>> > just fine.
>>
>> void * is probably good, otherwise we have to pull out structure definitions
>> (ok, there are two: solaris_cpu_t and cpu_core_t) from external/cddl.
>> opensolaris_init in external/cddl/osnet/sys/kern/opensolaris.c
>> is a good place to assign, I think.
>
> Using 'void *' causes problems with knowing which pointer is valid
> for a given call.
> There is no problem using 'struct foo *' without the contents of
> 'struct foo' being visible.

Oh yes, you're right...

  ozaki-r

>
>         David
>
> --
> David Laight: david%l8s.co.uk@localhost