Re: Porting DTrace to ARM

[Matt Thomas <matt%3am-software.com@localhost>]

On Jan 24, 2014, at 2:34 AM, Ryota Ozaki <ozaki-r%iij.ad.jp@localhost> wrote:

> Updated as I planned, there is no curious update though.

Use of curcpu() or cpu_number() without having done kpreempt_disable() is 
unsafe.

dtrace_asm.S doesn't "assym.h"
assembly routines should have a END(name) as well.
Use of =foo is frowned upon.

ENTRY(dtrace_invop_init)
        #ldr    r0, dtrace_invop_start
        ldr     r1, .Ldtrace_invop
        ldr     r2, .Ldtrace_invop_jump_addr
        str     r1, [r2]
        RET
        .align  0
.Ldtrace_invop:
        .word   dtrace_invop
.Ldtrace_invop_jump_addr
        .word   dtrace_invop_jump_addr
END(dtrace_invop_init)

ENTRY(dtrace_invop_uninit)
        mov     r0, #0
        ldr     r1, .Ldtrace_invop_jump_addr
        str     r0, [r1]
        RET
END(dtrace_invop_uninit)


external/cddl/osnet/dev/fbt/fbt.c:

Don't use u_int{8,16,32}_t

Makefiles:

Use include <bsd.own.mk>, then use

.if exists(${.CURDIR}/${MACHINE})
ARCHDIR=${MACHINE}
.elif exists(${.CURDIR}/${MACHINE_CPU})
ARCHDIR=${MACHINE_CPU}
.else
.error ${MACHINE} or ${MACHINE_CPU} not supported.
.endif