Port-arm archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Removing armfpe (was STACKCHECKS)



On Dec 5, 2012, at 1:36 AM, Masanobu SAITOH wrote:

> Hi.
> 
> It seems we can't compile kernel with STACKCHECKS.
> 
> Is the following patch correct?
> 
> Index: vm_machdep.c
> ===================================================================
> RCS file: /cvsroot/src/sys/arch/arm/arm32/vm_machdep.c,v
> retrieving revision 1.61
> diff -u -r1.61 vm_machdep.c
> --- vm_machdep.c      23 Oct 2012 22:50:00 -0000      1.61
> +++ vm_machdep.c      5 Dec 2012 09:26:43 -0000
> @@ -210,10 +210,12 @@
> #ifdef STACKCHECKS
>       /* Report how much stack has been used - debugging */
>       if (l) {
> +             vaddr_t uv;
>               u_char *ptr;
>               int loop;
> 
> -             ptr = (u_char *)pcb + USPACE_SVC_STACK_BOTTOM;
> +             uv = uvm_lwp_getuarea(l);
> +             ptr = (u_char *)(uv + USPACE_SVC_STACK_BOTTOM);
>               for (loop = 0; loop < (USPACE_SVC_STACK_TOP - 
> USPACE_SVC_STACK_BOTTOM)
>                   && *ptr == 0xdd; ++loop, ++ptr) ;
>               log(LOG_INFO, "%d bytes of svc stack fill pattern\n", loop);
> 
> 
> -- 

Since armfpe hasn't compiled since we switched to lwps in NetBSD 5.0, I think 
we should just remove it.  The log seems to be noisy and probably should only 
print if a new "stack low" is encountered.


Home | Main Index | Thread Index | Old Index