Subject: Re: port-shark/22355 [was: Help needed to fix NetBSD/shark]
To: Izumi Tsutsui <firstname.lastname@example.org>
From: Chris Gilbert <email@example.com>
Date: 08/07/2007 20:46:06
Izumi Tsutsui wrote:
> firstname.lastname@example.org wrote:
>> That all makes sense, can you commit your fix? Certianly for the
>> original issue where interrupts stop entirely, the fix to always look up
>> the mask is the best fix for now.
> sys/arm/iomd/iomd_irq.S has the similar code.
> I think we should also fix it, but is there anyone
> who try recent -crrent on acorn32?
I probably can this weekend, I've a eb7500atx, which is iomd based.
> If we fix both shark/isa/isa_irq.S and arm/iomd/iomd_irq.S,
> no other source refers the spl_mask variable (except debug printfs).
> Should we also remove it especially from arm/arm32/spl.S?
Yes we should, it avoids anyone thinking it still works, and it's one
less thing for spl to do.
>> My lingering concern is that the IPL level will be raised and block
>> interrupts for longer than it should. Perhaps this is more a concern on
>> slower hardware?
> Overblocking might cause clock delays (if IPL_BIO interrupts
> are handled at IPL_CLOCK), but it won't be fatal, I think.
I'm hoping it isn't fatal, but want to keep an eye on it.