Subject: Re: memmove problem
To: Katsumi Yamada <>
From: Richard Earnshaw <>
List: port-arm
Date: 02/01/2006 11:19:21
On Wed, 2006-02-01 at 08:26, Katsumi Yamada wrote:
> Hello,
> In src/sys/lib/libkern/arch/arm/memmove.S of the netbsd-3 branch 
> and the netbsd-2 branch, it seems that a part of lsl and lsr have changed 
> mutually places.
> When the following both conditions are satisfied, this problem happens:
>   * The source address(A) is greater than the destination address(B).
>   * remainder of (A-B)/4 is 1.
> I made the following patch that fixes this problem. Is this correct?

It certainly appears that the libc implementation already has the same
code as your proposed patch.  So I would think this probably is correct.

Steve, cvs annotate shows you checked in both implementations of
memmove.S: any comments?