Subject: Re: CVS commit: syssrc/sys/arch/arm32/arm32
To: None <email@example.com>
From: IWAMOTO Toshihiro <firstname.lastname@example.org>
Date: 06/27/2001 15:58:09
At Wed, 27 Jun 2001 01:09:22 +0300 (EEST),
Chris Gilbert wrote:
> Modified Files:
> syssrc/sys/arch/arm32/arm32: fault.c
> Log Message:
> Add checks (make non DIAGNOSTIC) to make sure that we never call uvm_fault from an interrupt.
> To generate a diff of this commit:
> cvs rdiff -r1.55 -r1.56 syssrc/sys/arch/arm32/arm32/fault.c
KASSERT expands to void when DIAGNOSTIC isn't defined. So I think the
check in data_abort_handler is better to be kept inside DIAGNOSITC
ifdef for consistency.
It might be even better to use KASSERT for the both of checks.
BTW, can we move it to arm/arm32/fault.c (and abandon hpcarm version)
to reduce maintainance load?