Re: FPU init patch (trivial), please review.

["Cherry G. Mathew" <cherry.g.mathew%gmail.com@localhost>]

On 6 March 2011 22:11, David Laight <david%l8s.co.uk@localhost> wrote:
> On Sun, Mar 06, 2011 at 09:06:45PM +0530, Cherry G. Mathew wrote:
>> Hi,
>>
>> The following diff [1] uses macros instead of frobbing flags directly,
>> when resetting the FPU. This diff omits clearing CR0_EM but I'm not
>> sure this is relevant for port-amd64 anyway since it's an npx related
>> bit.
>>
>> Could you please try this patch and confirm that it's safe to commit ?
>
> I'm not 100% sure why the extra level of obfustaction helps?
>

In general, using an already available interface abstraction.

My specific usecase eliminates the #ifdef XEN clause (domUs are
dissallowed from directly mucking with cr0).

Cheers,
-- 
~Cherry