Re: [PATCH] Warn on unhandled interrupts

[Matt Fleming <matt%console-pimps.org@localhost>]

On Sat, 29 May 2010 10:03:53 +0100, Matt Fleming 
<matt%console-pimps.org@localhost> wrote:
> Hi,
> 
> while chasing a spurious interrupt bug I realised that the kernel
> doesn't warn about unhandled interrupts on amd64. In fact, it ignores
> the return value of the interrupt handlers completely. I wrote the patch
> below so that the kernel will complain when an interrupt goes
> unhandled. The warning is rate limited to once every 5 seconds and it
> will only complain at most 10 times for any given slot.
> 
> Be aware that I haven't done much x86-64 assembly programming and so
> there could be some issues with the vector.S patch. For example, I've no
> idea if the kernel expects a particular alignment for the stack.
> 
> The patch is also available from,
> http://www.netbsd.org/~mjf/patches/amd64-spurious-interrupt.patch
> 
> Comments?

I've updated the patch at the above url because I noticed that it didn't
pop the 'handled' variable off the stack when branching to label
7. Hubert Feyrer also had a good idea of #define'ing the number of times
that the patch warns.

Does anyone have a problem with me committing this to HEAD? A couple of
people have said that it would be useful.