Port-amd64 archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: [PAE support] Types + cosmetic fixes

On Wed, Feb 24, 2010 at 12:18:13AM +0100, Jean-Yves Migeon wrote:
> > I don't know if anything outside kernel tries to read the PTE though.
> I am more worried about parts of code which happily use paddr_t as
> pd_entry_t (they should be limited to pmap though).

The pmap might want to explicitly use a smaller type.

> But this doesn't tell me: should I go the "typdef uint64_t paddr_t"
> route? This may have unexpected overhead (which I cannot assess),
> and might consume extra stack/register just to store bytes which
> will never be used in non-PAE situation.

I'd go for it. I suggest to carefully check a few places like twa(4) to
ensure they don't force 64bit PCI on !PAE kernels.


Home | Main Index | Thread Index | Old Index