Subject: Re: pciide performance on alpha
To: Michael T. Stolarchuk <email@example.com>
From: Andreas Johansson <firstname.lastname@example.org>
Date: 08/14/1999 00:11:37
On Fri, 13 Aug 1999, Michael T. Stolarchuk wrote:
> >I've attached the patch I use, it's for dev/pci/pci.c and you need to
> >define PCI_FORCE_LATENCY
> any specific value, or is -DPCI_FORCE_LATENCY enough?
Hmm.. I meant to cancel the mail, but instead I sent it.. :/
Anyway, I have a row with the text
in my config to force all latency timers to 32. One could change the patch
so that it only changes latencies that are 0.
> Oh, i also noticed:
> + v |= PCI_FORCE_LATENCY << PCI_LATTIMER_SHIFT;
> + pci_conf_write(pa.pa_pc, pa.pa_tag,
> + .pa_pc, pa.pa_tag,
> + PCI_BHLC_REG, v);
> is that right, six parameters to pci_conf_write, and two of them are ".pa_pc, pa.pa_tag,"
> i changed that to:
> pci_conf_write(pa.pa_pc, pa.pa_tag, PCI_BHLC_REG, v);
I don't know what's happened here, in my original file it says:
+ v |= PCI_FORCE_LATENCY << PCI_LATTIMER_SHIFT;
+ pci_conf_write(pa.pa_pc, pa.pa_tag,
+ PCI_BHLC_REG, v);