Please review wip/fldigi (3.21.50) for the update to ham/fldigi (3.03)
I've checked running on NetBSD/amd64 BETA2.
Thanks for doing this - it's a package I had been intending to get to
updating but haven't. The below sounds like a lot of complaints but I
think they're all minor.
0) I made a bunch of cosmetic edits to both ham/ and wip/, to make them
closer together, mostly so I could review the diffs.
1) I built it (NetBSD/i386 5.1_STABLE), but it fails to install:
/usr/bin/install -c -s -o gdt -g users -m 755 fldigi flarq
'/home/n0/ANONCVS/pkgsrc/wip/fldigi/work/.destdir/usr/pkg/bin'
install: exec of strip failed:
install: stripping
/home/n0/ANONCVS/pkgsrc/wip/fldigi/work/.destdir/usr/pkg/bin/fldigi: No such
file or directory
There is a a STRIP env var setting in ham/fldigi, missing in wip. It's
interesting that this works for you on netbsd-6.
2) I changed the HOMEPAGE to be the one in the README. Do you think the
mailinglist is better?
3) The -lossaudio seems wrong. In ham/, there is bl3 of ossaudio, which
will refer to base system libs. So I think we should add that back and
drop the explict lib link. What do you think?
4) portaudio, or pulseaudio? Both are bl3'd in - is that intentional,
and maybe there should be a comment.
5) jpeg is dropped. It seems to build, but do you know why it used to
be there?
6) WRKREF in binary from configure: does anyone know if this happens in
other packages, and what our usual approach is?
7) There are patches in ham/ and not in wip/. Have you looked at them
to make sure they no longer belong?
Greg Troxel <gdt%ir.bbn.com@localhost>
Attachment:
pgpDnTCCXiShu.pgp
Description: PGP signature
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________ pkgsrc-wip-review mailing list pkgsrc-wip-review%lists.sourceforge.net@localhost https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review