Re: please review baler and eor

[Thomas Klausner <thomasklausner%users.sourceforge.net@localhost>]

On Sat, Jan 15, 2011 at 07:11:27PM +0100, Jan Šmydke wrote:
> I decided not to use cmake at all so now eor uses a plain GNUmakefile
> only.
> 
> Could you please review it again?

eor doesn't work with destdir installs.
install -m 755 eor /usr/pkg/bin/eor
install: /usr/pkg/bin/eor: open: Permission denied

It should install to ${DESTDIR}${PREFIX}/bin then it would probably
work.

baler/patches/patch-aa should have a comment, e.g. "Fix destdir
installation."

Otherwise, they look fine.

Have you looked at archivers/par2? It does something similar, but uses
more complex algorithms and probably needs less extra data than eor.
 Thomas

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review