pkgsrc-WIP-review archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Please review wip/fop

On Thu, Jan 13, 2011 at 11:18:58AM +0100, Thomas Klausner wrote:
> On Thu, Jan 13, 2011 at 09:37:14AM +0100, Francois Tigeot wrote:
> > > Also it would be nice if bin/fop already set the JAVA_HOME environment
> > > variable correctly. In my environment I get
> > >   Error: JAVA_HOME is not defined correctly.
> > 
> > Is there an existing framework / package example I could use ?
> I suggest adding a patch for bin/fop that does
> around line 87 and then using SUBST_SED to replace "@JAVA_HOME@" with
> the value of the variable from pkgsrc (see section 19.1.12 in the
> pkgsrc guide for SUBST_SED). grep will give you lots of examples for

I was aware of SUBST_SED and replacement strings; but didn't know I could
use something as simple as a predefined JAVA_HOME variable.

I've seen nothing about this feature in the pkgsrc guide.

Francois Tigeot

Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
pkgsrc-wip-review mailing list

Home | Main Index | Thread Index | Old Index