pkgsrc-WIP-review archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Review-Request: wip/libpar2


On Sat, October 30, 2010 14:04, OBATA Akio wrote:

> * No need to add --prefix=... to CONFIGURE_ARGS, it will be automatically
> added
>    with GNU_CONFIGURE=yes.

Line removed and replaced with GNU_CONFIGURE=YES

> * Adding lib/libpar2 to BUILDLINK_LIBDIRS is probably not good
>    because it only contains a header file.

Line has been removed

> and you can clean `pkglint -Wall' warnings.


pkglint -Wall says "Looks fine", now.

Please review again.

- Volkmar


Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
pkgsrc-wip-review mailing list

Home | Main Index | Thread Index | Old Index