pkgsrc-WIP-review archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Please review wip/xvkbd



Thanks for your review.

From: "OBATA Akio" <obache%users.sourceforge.net@localhost>
Subject: Re: Please review wip/xvkbd
Date: Tue, 31 Aug 2010 11:13:44 +0900

> For man page handling, no need post-install target.
> It depend on platforms whether man and/or cat will be installed or not.
> (see mk/platform/*.mk)
> You can use ${IMAKE_MANDIR}/foo.${IMAKE_MAN_SUFFIX} in PLIST.

I understood this.


> There are some missing buildlink.
> In Imakefile, XTEST is defined, so xtest related packages should be 
> buildlinked.
> If xaw option is enabled, x11/libXaw must be buildlinked.
> And you may include mk/xaw.buildlink3.mk and switch condition in Imakefile
> with XAW_TYPE.

I added missing buildlinks.

But I cannot usage of XAW_TYPE.
Do you know good example?

--
Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3



------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:

Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review


Home | Main Index | Thread Index | Old Index