Re: Please review llgal

["OBATA Akio" <obache%users.sourceforge.net@localhost>]

Hi,

On Sun, 28 Mar 2010 20:54:55 +0900, Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost> 
wrote:

> Hi,
>
> I committed llgal package.
> This is static HTML photo gallery generator written by perl.
>
> I am not familiar with creating a perl package.
>
> Please review this package.

No need to patch-aa, add following in pkgsrc Makefile:
MAKE_FLAGS+=    PERL_INSTALLDIRS=vendor
INSTALL_TARGET= install installq-man

And, also add following to MAKE_FLAGS
* LOCALEDIR=${PREFIX}/${PKGLOCALEDIR}/locale (and USE_PKGLOCALEDIR=yes in 
pkgsrc Makefile)
* MANDIR=${PREFIX}/${PKGMANDIR}
* SYSCONFDIR=${PKG_SYSCONFBASE}

No need to define, it is used indirectly.
PERL5_MODULE_TYPE=      MakeMaker

about SUBST_*
probably no need to fix-paths, ${PREFIX} will be passed as MAKE_FLAGS.
for interpreter, use can use REPLACE_PERL+=llgal.in instead.

USE_LANGUAGES is empty, so I guess no need to buildlink to ImakgeMagick,
just simply DEPENDS is sufficient.

include "../../lang/perl5/buildlink3.mk" is redundant.

perl module related files should not be in PLIST, because you already define
PERL5_PACKLIST.

no need "@pkgdir etc/llgal" in PLIST, define PKG_SYSCONFSUBDIR=llgal and 
treated automatically.
-- 
"Of course I love NetBSD":-)
OBATA Akio / obache%users.sourceforge.net@localhost

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review