pkgsrc-WIP-review archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Please review wip/i3


On Mon, Mar 23, 2009 at 02:16:34PM +0100, Michael Stapelberg wrote:
> Hi,
> please review the new package wip/i3. i3 is an improved dynamic tiling window
> manager.

I have two comments:

- CATEGORIES should probably be set to 'wm'

- In patch-aa, the prefix path is hardcoded to /usr/pkg which is not
  optimal. Perhaps you could use the SUBST framework[1] instead.

[1] The pkgsrc guide 19.1.12

Best regards,


Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial.
pkgsrc-wip-review mailing list

Home | Main Index | Thread Index | Old Index