ibevent

[Christian Sturm <athaba%inode.at@localhost>]

Hi,

could you please review the libevent package. As I already wrote 
it is based on devel/libevent and contains all patches which are 
not already in libevent now. Since I never really learned C I'm 
not compltly sure if all of them are still needed. I copied the 
parts, which are still missing in the orginal sources.

I want a new, review because they are now tagged with -stable 
(last time I asked for a review, they were -alpha) and could be 
copied to pkgsrc. I have been using 1.4.x series with tor (both, 
client and server) and never had any issues, so I think they 
should be compatible.

Oh, could someone have a look at the builtin.mk. That's maybe the 
only thing left. I read the "Buildlink methodology" chapter, but 
I'm not sure how it works.

This part(s) looks confusing to me:
*snip*
.if !defined(BUILTIN_PKG.libevent) && \
    !empty(IS_BUILTIN.libevent:M[yY][eE][sS]) && \
    empty(H_LIBEVENT:M__nonexistent__)
# libevent>=1.3: bufferevent_base_set added
_BLTN_EVENT_13!=        \
        ${GREP} -c bufferevent_base_set ${H_LIBEVENT} || ${TRUE}
*snip*

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review