pkgsrc-WIP-review archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: epsg package



Greg Troxel writes:
 > 
 > I concur with Joerg's comments.   For primary category, the question
 > is who's likely to find this looking where, and while this is a
 > database thing, that's the means, and geography is the end.

Done.  (I presume the first category is taken to be the primary one.)

 > The license terms are very clearly not "open source" or "Free", and
 > thus LICENSE= and having the license is in order.  Set RESTRICTED, and
 > then I agree that NO_{SRC,BIN}_ON_CDROM is in order, and there's no
 > issue with a binary package over FTP so NO_{SRC,BIN}_ON_FTP can be
 > left unset.  (In pkgsrc, CDROM ::= for a fee, and FTP ::= at no cost,
 > even though that's a bit goofy.)

Done.  I don't seem to find a 'licenses' directory within pkgsrc-wip,
which would normally be the spot for a file called epsg-license in
this case.  Where is the license file supposed to go in the meantime?
Is it standard practice to do something like I did, i.e., leave a file
in the package directory?

 > These people are geodesy nerds, not lawyers, and it's clear that
 > Brook's packaging and normal use of it satisfies their "no
 > modification intent", which is surely about integrity of the
 > parameters and OGC's reputation.  I see no need to worry here.
 > Processing the data on one's machine is not clearly subject to
 > copyright anyway.

This is exactly right. They are concerned with the provenance of the
paramter values, not the format (e.g., sql text, tar file, ...) they
are presented in.

 > The 2 doc files probably belong in share/doc/epsg instead of
 > share/epsg.

Done.  I also added part 2 of the docs.

 > I see no point in splitting this into mysql and pgsql separate
 > packages (you didn't ask, but it's an obvious question).

I had already given some thought to this and came to the same
conclusion.  That is why I didn't ask.  Glad you agree.

Anyway, I think with these changes and pending further review, the
epsg package is done.

Please let me know if there are other points I missed.  If not, I
would appreciate it if if was committed to pkgsrc.

Thanks alot for your speedy review.

Cheers,
Brook

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review



Home | Main Index | Thread Index | Old Index