Re: Please review asterisk

[Thomas Klausner <thomasklausner%users.sourceforge.net@localhost>]

On Wed, Mar 16, 2005 at 02:03:49PM -0800, Jeff Rizzo wrote:
> I'd appreciate it if anyone with even a passing interest in the Asterisk
> software PBX on NetBSD to please look at this package (and
> zaptel-netbsd) and give me your feedback.  I'd like to get this polished
> and moved over to pkgsrc proper sometime after the freeze is over...

pkglint is happy.

CATEGORIES does not contain a proper category (for the import).

TODO contains one remaining item:
- add option for graphic console support.  Haven't looked at this yet, not
  sure how necessary it is.

options.mk:
Perhaps you should use PLIST_SUBST for zaptel instead,
then you could use the default PLIST_SRC handling.

First chunk of patch-aa looks wrong.

patch-ab: should the pbx_gtkconsole be made an option?
(hm, seems to be the TODO item :) ).

Builds, installs, and deinstalls cleanly on 2.0/i386.

zaptel-netbsd:

pkglint is happy.

CATEGORIES has same problem as asterisk.

Builds and installs cleanly.

Leaves etc/zaptel.conf on deinstall -- why is it not removed automatically?
[I didn't change it.]

Leaves lkm on deinstall -- should be removed with
@unexec ${RMDIR} %D/lkm 2>/dev/null || ${TRUE}

newt:

pkglint is happy.

DISTFILE: is there no real source release, only the redhat rpm?
WRKDIR=${WRKSRC}/${PKGNAME_NOREV} is perhaps better for updates.

do-extract: prefix rpm2pkg with its path, like ${LOCALBASE}/bin/rpm2pkg.

do-install: the whiptail installation looks wrong. It should be installed
by libtool, like the library.

TODO has two entries:
- Add Python and TCL support options
- deal a bit better with libtool - shouldn't have to install whiptail from
  ${WRKSRC}/.libs

Ah yes, that's just what I said :)

Shouldn't
${LIBTOOL} --mode=install ${INSTALL} whiptail ${PREFIX}/bin
in the right directory work?

How about the tcl and python options?

Builds, installs, and deinstalls cleanly.

 Thomas


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review