Re: Please review: wip/wordnet

[Min Sik Kim <minskim%NetBSD.org@localhost>]

On Mar 3, 2005, at 4:12 AM, Peter Bex wrote:

> Hello all,
>
> I just added wordnet, a package which contains a list of all(?) English
> words, their meaning, synonyms, antonyms and familiarity with the word 
> of
> the average English speaker.

Thank you for packaging this.  I have a few suggestions.

1. It doesn't build on Darwin, because wnutil.c includes malloc.h.  The 
standard place for malloc prototype is stdlib.h.

2. Tcl/Tk prefix should be ${BUILDLINK_PREFIX.tcl} and 
${BUILDLINK_PREFIX.tk}, not ${PREFIX}, which is incorrect in the 
pkgviews world.

3. Do not override CC, CFLAGS, LDFLAGS etc. set by pkgsrc.  Append 
using "+=" if needed.

4. Include buildlink3.mk files before defining the pre-build target.  
See pkgsrc/doc/Makefile-example for more information.

Regards,
Min Sik Kim



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review