Re: Unable to ci wip/Makefile

[Roland Illig <rillig%NetBSD.org@localhost>]

Mehul Sanghvi wrote:
> So I've got my first package into pkgsrc-wip.  Anyone want to point out
> problems with it ? :)

- PKGNAME must have a version number. It should be vtwm-5.4.7.
- But you don't need to specify PKGNAME at all
  if it is the same as DISTNAME.
- WRKSRC defaults to ${WRKDIR}/${DISTNAME}, so you don't need to set it.
- COMMENT should not end with a period.

The definitions should be aligned vertically. In your case I suggest 
that they all start in column 16. They should be indented by tabs, not 
by spaces.

The rest looks fine.

Roland


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
pkgsrc-wip-discuss mailing list
pkgsrc-wip-discuss%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-discuss