Re: plink2: Update to latest commit, add -march=native option

[maya%netbsd.org@localhost]

It's a weird package option, wouldn't you want to use
CFLAGS+=-march=native globally for all packages if you are OK with it,
rather than enable an option?

On Sun, May 06, 2018 at 02:08:41AM +0000, Jason Bacon wrote:
> Module Name:	pkgsrc-wip
> Committed By:	Jason Bacon <bacon%NetBSD.org@localhost>
> Pushed By:	outpaddling
> Date:		Sat May 5 21:08:41 2018 -0500
> Changeset:	9df3f64ddf4eab37a9264404b94801c1ee2e9710
> 
> Modified Files:
> 	plink2/Makefile
> 	plink2/distinfo
> Added Files:
> 	plink2/options.mk
> 
> Log Message:
> plink2: Update to latest commit, add -march=native option
> 
> To see a diff of this commit:
> https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=9df3f64ddf4eab37a9264404b94801c1ee2e9710
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
> 
> diffstat:
>  plink2/Makefile   | 11 +++++++----
>  plink2/distinfo   |  8 ++++----
>  plink2/options.mk |  8 ++++++++
>  3 files changed, 19 insertions(+), 8 deletions(-)
> 
> diffs:
> diff --git a/plink2/Makefile b/plink2/Makefile
> index e007fd5f05..3a8cb5cffb 100644
> --- a/plink2/Makefile
> +++ b/plink2/Makefile
> @@ -9,7 +9,7 @@ DISTNAME=	plink-ng-${PORTVERSION}
>  CATEGORIES=	biology
>  MASTER_SITES=	${MASTER_SITE_GITHUB:=chrchang/}
>  GITHUB_PROJECT=	plink-ng
> -GITHUB_TAG=	e81056a32d67cd73a69579e2dbb374d16196f305
> +GITHUB_TAG=	16230ed1c386312ab233ac98e414f67e28f72b4d
>  
>  MAINTAINER=	bacon%NetBSD.org@localhost
>  HOMEPAGE=	http://pngu.mgh.harvard.edu/~purcell/plink/
> @@ -23,17 +23,20 @@ GCC_REQD+=	5.0
>  
>  WRKSRC=		${WRKDIR}/${GITHUB_PROJECT}-${GITHUB_TAG}/2.0
>  
> -CFLAGS+=	-DDYNAMIC_ZLIB -I${PREFIX}/include -g
> -CXXFLAGS+=	-DDYNAMIC_ZLIB -I${PREFIX}/include -g
> +CFLAGS+=	-g -DDYNAMIC_ZLIB -I${PREFIX}/include
> +CXXFLAGS+=	-g -DDYNAMIC_ZLIB -I${PREFIX}/include
>  
>  # Check this
>  # MAKE_FLAGS+=	ZLIB=-lz BLASFLAGS64="-L${PREFIX}/lib -lopenblas"
>  MAKE_FLAGS+=	ZLIB=-lz BLASFLAGS64="-L${PREFIX}/lib -llapack -lcblas -lblas"
> +# Keep debug info until at least next beta
>  # INSTALL_TARGET=	install-strip
>  
> -PORTVERSION=	0.0.0.20180503
> +PORTVERSION=	0.0.0.20180504
>  # PREFER.zlib=pkgsrc	# Requires newer version than NetBSD 7.1 provides
>  
> +.include "options.mk"
> +
>  #.include "../../wip/openblas_pthread/buildlink3.mk"
>  .include "../../math/blas/buildlink3.mk"
>  .include "../../math/lapack/buildlink3.mk"
> diff --git a/plink2/distinfo b/plink2/distinfo
> index f7141cd103..2a4b13599f 100644
> --- a/plink2/distinfo
> +++ b/plink2/distinfo
> @@ -1,8 +1,8 @@
>  $NetBSD$
>  
> -SHA1 (plink-ng-0.0.0.20180503-e81056a32d67cd73a69579e2dbb374d16196f305.tar.gz) = 1616e95b928da07cdbe237e7558ff6085ae7a0fa
> -RMD160 (plink-ng-0.0.0.20180503-e81056a32d67cd73a69579e2dbb374d16196f305.tar.gz) = 3a064362785e5193070df2a7027f714912a671c2
> -SHA512 (plink-ng-0.0.0.20180503-e81056a32d67cd73a69579e2dbb374d16196f305.tar.gz) = c6dc6d187f1664e3489817dbe6ba0a19c548a9b9e42b7033cb751f2254b6a66ebd0b562663924bcca351db0d4bcabb2683a79cfd1339777fea7ac8d3f2965650
> -Size (plink-ng-0.0.0.20180503-e81056a32d67cd73a69579e2dbb374d16196f305.tar.gz) = 2363822 bytes
> +SHA1 (plink-ng-0.0.0.20180504-16230ed1c386312ab233ac98e414f67e28f72b4d.tar.gz) = c1967a0d9eddc7a3609cbab8c378086154f33209
> +RMD160 (plink-ng-0.0.0.20180504-16230ed1c386312ab233ac98e414f67e28f72b4d.tar.gz) = 435c7a4b4ce707e1e3aa796f2e162d1ea67927e1
> +SHA512 (plink-ng-0.0.0.20180504-16230ed1c386312ab233ac98e414f67e28f72b4d.tar.gz) = 25a3010b3174367b2e5b61268eb3d00748f1026eafab4da2c77b54142fe6ca2532f7d37a5e466d8f774c7c855e9aecbbfb82c2390245791957f3b75874ca3c62
> +Size (plink-ng-0.0.0.20180504-16230ed1c386312ab233ac98e414f67e28f72b4d.tar.gz) = 2363703 bytes
>  SHA1 (patch-Makefile) = 6b3a3e639922fdb430b76e06a608dd25df6e528c
>  SHA1 (patch-plink2__base.h) = 08cc1710f2824985dc132149ca102f82e0488bf1
> diff --git a/plink2/options.mk b/plink2/options.mk
> new file mode 100644
> index 0000000000..5c0badb2a5
> --- /dev/null
> +++ b/plink2/options.mk
> @@ -0,0 +1,8 @@
> +PKG_OPTIONS_VAR=	PKG_OPTIONS.plink2
> +PKG_SUPPORTED_OPTIONS=	native
> +
> +.include "../../mk/bsd.options.mk"
> +
> +.if !empty(PKG_OPTIONS:Mnative)
> +CFLAGS+=	-march=native
> +.endif