bitcoin: Fold TODO into Makefile and update

[Greg Troxel <gdt%ir.bbn.com@localhost>]

Module Name:	pkgsrc-wip
Committed By:	Greg Troxel <gdt%ir.bbn.com@localhost>
Pushed By:	gdt
Date:		Tue Nov 29 11:22:34 2016 -0500
Changeset:	dec619f86a4c6f2d286d4871d7a2c414044482fb

Modified Files:
	bitcoin/Makefile
	bitcoin/options.mk
Removed Files:
	bitcoin/TODO

Log Message:
bitcoin: Fold TODO into Makefile and update

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=dec619f86a4c6f2d286d4871d7a2c414044482fb

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 bitcoin/Makefile   | 4 +++-
 bitcoin/TODO       | 6 ------
 bitcoin/options.mk | 7 +++++++
 3 files changed, 10 insertions(+), 7 deletions(-)

diffs:
diff --git a/bitcoin/Makefile b/bitcoin/Makefile
index ddb2329..97cbce7 100644
--- a/bitcoin/Makefile
+++ b/bitcoin/Makefile
@@ -1,5 +1,6 @@
 # $NetBSD$
 
+# TODO: update to latest release
 DISTNAME=       bitcoin-0.11.2
 PKGREVISION=    3
 CATEGORIES=	finance
@@ -61,8 +62,9 @@ SUBST_MESSAGE.pkg=	Fixing /usr references to ${PREFIX}.
 pre-configure:
 	cd ${WRKSRC} && ./autogen.sh
 
-# bitcoin appears to have a functioning install target, so this should
+# TODO: bitcoin appears to have a functioning install target, so this should
 # not be necessary.
+# TODO: bitcoind is a bin_PROGRAM, not sbin_PROGRAM, per upstream.
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/src/bitcoin-cli ${DESTDIR}${PREFIX}/bin
 	${INSTALL_PROGRAM} ${WRKSRC}/src/.libs/bitcoind ${DESTDIR}${PREFIX}/sbin
diff --git a/bitcoin/TODO b/bitcoin/TODO
deleted file mode 100644
index 151ba93..0000000
--- a/bitcoin/TODO
+++ /dev/null
@@ -1,6 +0,0 @@
-* Update to latest release;
-* Make Qt optional in options.mk;
-* Add bitcoin-qt4 and bitcoin-qt5 packages using qt{4,5} options, respectively;
-* If both Qt4 and Qt5 are installed, package will default to Qt4;
-* Check documentation for other package options;
-* Fix configure/build/install phases for latest version;
diff --git a/bitcoin/options.mk b/bitcoin/options.mk
index d05c648..67e2427 100644
--- a/bitcoin/options.mk
+++ b/bitcoin/options.mk
@@ -1,5 +1,8 @@
 # $NetBSD$
 
+# TODO: make qt optional, and support qt5
+# TODO: create split package for qt gui
+
 PKG_OPTIONS_VAR=		PKG_OPTIONS.bitcoin
 PKG_SUPPORTED_OPTIONS+=		miniupnpc dbus qrcode
 PKG_SUGGESTED_OPTIONS+=		dbus qrcode
@@ -10,10 +13,14 @@ PKG_SUGGESTED_OPTIONS+=		dbus qrcode
 .include "../../wip/miniupnpc/buildlink3.mk"
 .endif
 
+# TODO: Add a comment explaining what this does, and decide if it
+# should just be enabled instead of being an option.
 .if !empty(PKG_OPTIONS:Mdbus)
 .include "../../x11/qt4-qdbus/buildlink3.mk"
 .endif
 
+# TODO: If this is small, and only useful with qt, just depend
+# on it when qt is enabled.
 .if !empty(PKG_OPTIONS:Mqrcode)
 .include "../../converters/qrencode/buildlink3.mk"
 .endif