Subject: fastcgi and www/php4
To: None <pkgsrc-users@netbsd.org>
From: Jeremy C. Reed <reed@reedmedia.net>
List: pkgsrc-users
Date: 10/24/2007 12:21:40
I see if fastcgi is enabled for www/php4, then cgi option is disabled so 
it is not built with --enable-discard-path nor 
--enable-force-cgi-redirect.

Some documentation for fastcgi suggests that these be configured for 
fastcgi also.

I also don't understand why it has a PKG_OPTIONS_GROUP.sapi for this since 
it is always built with cgi (since no --disable-cgi).

I am testing the following. Any comments on this?


Index: www/php4/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/www/php4/Makefile,v
retrieving revision 1.79
diff -u -r1.79 Makefile
--- www/php4/Makefile	1 Aug 2007 01:40:54 -0000	1.79
+++ www/php4/Makefile	24 Oct 2007 17:12:15 -0000
@@ -13,16 +13,12 @@
 LIBTOOL_OVERRIDE=	# empty
 USE_TOOLS+=		gmake lex
 
-PKG_OPTIONS_REQUIRED_GROUPS+=	sapi
-PKG_OPTIONS_GROUP.sapi=	cgi fastcgi
-PKG_SUGGESTED_OPTIONS+=	cgi
+PKG_SUPPORTED_OPTIONS+=	fastcgi
 
 .include "Makefile.php"
 
-.if !empty(PKG_OPTIONS:Mcgi)
 CONFIGURE_ARGS+=	--enable-discard-path
 CONFIGURE_ARGS+=	--enable-force-cgi-redirect
-.endif
 
 .if !empty(PKG_OPTIONS:Mfastcgi)
 CONFIGURE_ARGS+=	--enable-fastcgi

  Jeremy C. Reed