Subject: Re: do we need to check for text files in subst.mk? (was Re:
To: None <pkgsrc-users@netbsd.org>
From: Joerg Sonnenberger <joerg@britannica.bec.de>
List: pkgsrc-users
Date: 10/04/2007 21:12:17
On Thu, Oct 04, 2007 at 09:02:59PM +0200, Klaus Heinz wrote:
> The check I am talking about is _SUBST_IS_TEXT_FILE in mk/subst.mk.
> Why do we need to check for the "text" property of a file if we
> explicitly specify the files where substitutions ought to be done? The
> simple solution: do not list files in SUBST_FILES.* which are not text
> files.

Because the use generic patterns in a number of places. Not all SUBST
users specify explicit file lists.

Joerg