Re: CVS commit: pkgsrc/devel/scmcvs

[Greg Troxel <gdt%lexort.com@localhost>]

"Hubert Feyrer" <hubertf%netbsd.org@localhost> writes:

> Module Name:  pkgsrc
> Committed By: hubertf
> Date:         Sat Sep 26 11:52:42 UTC 2026
>
> Modified Files:
>       pkgsrc/devel/scmcvs: Makefile
>
> Log Message:
> Make this build e.g. on macOS, see PR pkg/60769 for details.

Would be nice to "describe the change" in the commit message, which
seems like it would be compact.

> @@ -27,6 +27,12 @@ TEXINFO_REQD+=             4.0
>  
>  CONFIGURE_ARGS.Darwin+=      --enable-case-sensitivity
>  
> +.include "../../mk/bsd.prefs.mk"
> +
> +.if ${OPSYS} == "Darwin"
> +FORCE_C_STD=         gnu99
> +.endif
> +
>  .include "options.mk"
>  
>  AUTOCONF_REQD=               2.50

I would guess that cvs was written (or rather updated to, at some point)
c99, perhaps using gnu extensions, and did not contemplate the modern
insanity of a C compiler defaulting to new std without asking for it.

Why it this conditioned on Darwin?  That's an OS, not a compiler, and
the issue could well be "compiler so new it thinks c23 is a good
default".  (I would prefer that there be a comment that explains the
why, because it's really not obvious.)