CVS commit: pkgsrc/www/webkit-gtk41

["Greg Troxel" <gdt%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   gdt
Date:           Fri Sep 11 10:43:07 UTC 2026

Modified Files:
        pkgsrc/www/webkit-gtk41: Makefile.common

Log Message:
www/webkit-gtk41: Revise comment about finding sqlite3

This is a comment-only change.

Somehow, cmake finds libraries in the buildlink path instead of the
real path.  For most of them, the -L/rpath stuff ends up correct in
the built library.  For sqlite3, for me on NetBSD 10 amd64 building
normally (not bulk), the buildlink path ends up in the final library.
Explain the problem better.


To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 pkgsrc/www/webkit-gtk41/Makefile.common

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/www/webkit-gtk41/Makefile.common
diff -u pkgsrc/www/webkit-gtk41/Makefile.common:1.3 pkgsrc/www/webkit-gtk41/Makefile.common:1.4
--- pkgsrc/www/webkit-gtk41/Makefile.common:1.3 Fri Sep  4 16:05:35 2026
+++ pkgsrc/www/webkit-gtk41/Makefile.common     Fri Sep 11 10:43:07 2026
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile.common,v 1.3 2026/09/04 16:05:35 tnn Exp $
+# $NetBSD: Makefile.common,v 1.4 2026/09/11 10:43:07 gdt Exp $
 # used by www/webkit-gtk41/Makefile
 # used by www/webkit-gtk60/Makefile
 
@@ -58,7 +58,12 @@ CMAKE_CONFIGURE_ARGS+=               -DUSE_LIBBACKTRA
 .if ${OPSYS} == "Darwin"
 CMAKE_CONFIGURE_ARGS+=         -DUSE_LIBDRM=OFF
 .endif
-# otherwise, libsqlite3.so from ${BUILDLINK_DIR} is hardcoded into some binaries
+# Upstream cmake somehow finds the full path to sqlite3 in the
+# buildlink3 dir and that ends up in the library, at least in some
+# build environments.  This argument setting does not appear to work
+# in all situations.
+#   $ ldd work/.destdir/usr/pkg/lib/libwebkit2gtk-4.1.so.0.21.10|egrep sqli
+#   /tmp/work/www/webkit-gtk41/work/.buildlink/lib/libsqlite3.so => /tmp/work/www/webkit-gtk41/work/.buildlink/lib/libsqlite3.so
 CMAKE_CONFIGURE_ARGS+=         -DSQLite3_LIBRARY=${BUILDLINK_PREFIX.sqlite3}/lib/libsqlite3.so
 
 # required for faking a better user-agent