Re: CVS commit: pkgsrc/mail/isync

[Ryo ONODERA <ryo%tetera.org@localhost>]

Hi,

Kevin Bloom <ktnb%netbsd.org@localhost> writes:

>>
>> Hi,
>>
>> Your another commit fixes UTF-8 bug.
>> Thank you so much for your fix.
>>
>> I will run some more tests with my accounts.
>>
>
> I tested it out with some Japanese characters and it seems to have
> fixed it. Let me know if it doesn't work!

Your fix works fine for my accounts with folder names
in Japanese, Korean and Russian.

Thanks again.

>> Ryo ONODERA <ryo%tetera.org@localhost> writes:
>>
>> > Hi,
>> >
>> > Sadly mbsync command from mail/isync-1.5.1 cannot handle multibyte
>> > far side box names.
>> > 1.4.4 handles multibyte box name in modified UTF-7. It works.
>> > 1.5.0 and later try to handle them in raw UTF-8.
>> > However in this case, mbsync-1.5.1 gets segafult always.
>> >
>> > Please revert the following commit and stay 1.4.4nb3.
>> >
>> > Thank you.
>> >
>> > "Kevin Bloom" <ktnb%netbsd.org@localhost> writes:
>> >
>> >> Module Name:      pkgsrc
>> >> Committed By:     ktnb
>> >> Date:             Thu May 14 13:15:14 UTC 2026
>> >>
>> >> Modified Files:
>> >>   pkgsrc/mail/isync: Makefile distinfo
>> >>   pkgsrc/mail/isync/patches: patch-src_Makefile.in
>> >> Added Files:
>> >>   pkgsrc/mail/isync/patches: patch-src_config.c
>> >> Removed Files:
>> >>   pkgsrc/mail/isync/patches: patch-ae patch-src_drv__imap.c
>> >>       patch-src_socket.c patch-src_socket.h
>> >>
>> >> Log Message:
>> >> isync: update to 1.5.1
>> >>
>> >> 1.5.1 (2025-03-11)
>> >> ==================
>> >>
>> >> Improvements:
>> >>
>> >> - mbsync-get-cert now supports STARTTLS; new option -s
>> >> - Zero-sized messages from IMAP Stores are now accepted
>> >> - UIDVALIDITY change recovery is now attempted even if both sides of
>> >>   the Channel are affected
>> >> - The sync summary at the end is more concise again
>> >> - Cosmetic improvements to some console output
>> >>
>> >> Bug Fixes:
>> >>
>> >> - Fixed IMAP INBOX not being properly recognized with some servers
>> >> - Fixed Maildir INBOX nested into Path not being implicitly listed
>> >> - Fixed crash when resuming message propagation with MaxMessages
>> >> - Fixed --list-stores hanging after synchronous error
>> >> - Fixed --dry-run without --debug-driver not being really dry
>> >> - Fixed building from pristine git clones
>> >> - Fixed building from shallow git clones
>> >>
>> >> 1.5.0 (2024-08-02)
>> >> ==================
>> >>
>> >> Compatibility Concerns:
>> >>
>> >> - The reference point for relative local paths in the configuration file
>> >>   is now the file's containing directory
>> >> - Maildir Path cannot be nested into Inbox anymore (this was never documented)
>> >> - Renamed the ReNew/--renew/-N options to Upgrade/--upgrade/-u and
>> >>   Delete/--delete/-d to Gone/--gone/-g
>> >> - Superseded SSLVersions option with TLSVersions, and disabled TLS v1.0
>> >>   and v1.1 by default
>> >> - Renamed SSLType option to TLSType
>> >> - Placeholders will be now created for messages exceeding MaxSize even if they
>> >>   are flagged on the source side
>> >> - Placeholder upgrades no longer pull flag updates along unless also requested
>> >> - New messages which we are about to expunge from the source side are not
>> >>   propaged any more even if the target side would keep them
>> >> - Tunnel is now consistently assumed to be secure, so some warnings are gone
>> >>
>> >> New Features:
>> >>
>> >> - Changed default config & state locations to follow the XDG basedir spec;
>> >>   the old locations remain supported
>> >> - Added support for IMAP mailbox names with non-ASCII characters
>> >> - Added support for Maildir Paths with suffixes (not ending with a slash)
>> >> - Made the Channel side to expire with MaxMessages configurable
>> >> - MaxMessages and MaxSize can be used together now
>> >> - The unfiltered list of mailboxes in each Store can be printed now
>> >> - A proper summary is now printed prior to exiting.
>> >>   This includes expunges, which are now included in the progress as well.
>> >> - Added support for mirroring deletions more accurately; option ExpungeSolo
>> >> - Added new sync operation 'Old' to retry previously skipped messages
>> >> - Added --ext-exit option to indicate with the exit code whether Stores
>> >>   were modified
>> >> - Added --dry-run option
>> >>
>> >> Improvements:
>> >>
>> >> - Added support for the LITERAL- IMAP extension, which improves upload
>> >>   performance with f.ex. GMail somewhat
>> >> - Improved error handling when attempting to store too big messages on
>> >>   f.ex. GMail
>> >> - Malformed messages with incomplete headers will be propagated now
>> >> - A notice is now emitted if the server does not support race-free Trash
>> >> - Improved checking for invalid command lines
>> >> - Options not supported due to the build configuration are still recognized
>> >>   now, to make error messages more helpful
>> >> - The progress indicator is rate-limited now
>> >> - Various improvements to the debugging output
>> >> - Vastly extended the autotest suite
>> >>
>> >> Bug Fixes:
>> >>
>> >> - Worked around "unexpected EOF" error messages at end of TLS connections;
>> >>   affects f.ex. GMail
>> >> - Worked around protocol corruption issue with iCloud (mail.me.com)
>> >> - Fixed missing CAPABILITY command after logging in if the server does not
>> >>   report updated capabilities automatically (affects f.ex. MS Exchange)
>> >> - Fixed CopyArrivalDate failing on some date strings
>> >> - Fixed propagation of new messages to non-UIDPLUS servers
>> >> - Fixed Timeout being ignored by DNS host resolution
>> >> - Fixed broken Tunnel potentially causing SIGPIPE
>> >> - Fixed Tunnel leaving behind zombie processes
>> >> - Fixed expunges not being propagated at all if the first run after they
>> >>   occurred did not include --delete
>> >> - Fixed MaxMessages being exceeded when only --new was used
>> >> - Fixed messages being instantly expired despite being important when only
>> >>   --new was used
>> >> - Trash-ing failures now prevent expunging and cause a non-zero exit code
>> >> - Fixed placeholders being needlessly trashed
>> >> - Fixed TrashNewOnly and TrashRemoteNew omitting messages for which only
>> >>   a placeholder was synced
>> >> - Fixed TrashRemoteNew omitting messages which exceed MaxSize
>> >> - Fixed TrashRemoteNew not using race-free expunge
>> >> - Optimized some places with unnecessarily high CPU usage
>> >> - Fixed unnecessary network usage by non-selective uni-directional syncs when
>> >>   no placeholders are present
>> >> - Fixed crash when Patterns yields nothing when built with new compilers
>> >> - Fixed crash when all flag propagations to a mailbox failed
>> >> - Fixed handling of errors during opening mailboxes
>> >> - Removed useless "lost track of ... messages" warnings when resuming after
>> >>   an interruption
>> >> - Fixed many minor bugs in corner cases, mostly when resuming after
>> >>   interruptions
>> >>
>> >> 1.4.4 (2021-12-03)
>> >> ==================
>> >>
>> >> Bug Fixes:
>> >>
>> >> - Fixed CVE-2021-3657: multiple buffer overflows on excessively large
>> >>   IMAP literals
>> >> - Fixed CVE-2021-44143: buffer overflow on header-less messages
>> >> - Fixed crash on certain malformed messages in Maildirs
>> >> - Fixed somewhat spurious notice about conflicting changes on
>> >>   messages marked as deleted
>> >>
>> >>
>> >> To generate a diff of this commit:
>> >> cvs rdiff -u -r1.60 -r1.61 pkgsrc/mail/isync/Makefile
>> >> cvs rdiff -u -r1.26 -r1.27 pkgsrc/mail/isync/distinfo
>> >> cvs rdiff -u -r1.7 -r0 pkgsrc/mail/isync/patches/patch-ae
>> >> cvs rdiff -u -r1.3 -r1.4 pkgsrc/mail/isync/patches/patch-src_Makefile.in
>> >> cvs rdiff -u -r0 -r1.1 pkgsrc/mail/isync/patches/patch-src_config.c
>> >> cvs rdiff -u -r1.4 -r0 pkgsrc/mail/isync/patches/patch-src_drv__imap.c
>> >> cvs rdiff -u -r1.8 -r0 pkgsrc/mail/isync/patches/patch-src_socket.c
>> >> cvs rdiff -u -r1.1 -r0 pkgsrc/mail/isync/patches/patch-src_socket.h
>> >>
>> >> Please note that diffs are not public domain; they are subject to the
>> >> copyright notices on the relevant files.
>> >>
>> >> Modified files:
>> >>
>> >> Index: pkgsrc/mail/isync/Makefile
>> >> diff -u pkgsrc/mail/isync/Makefile:1.60 pkgsrc/mail/isync/Makefile:1.61
>> >> --- pkgsrc/mail/isync/Makefile:1.60       Mon Nov 17 11:01:04 2025
>> >> +++ pkgsrc/mail/isync/Makefile    Thu May 14 13:15:13 2026
>> >> @@ -1,7 +1,6 @@
>> >> -# $NetBSD: Makefile,v 1.60 2025/11/17 11:01:04 wiz Exp $
>> >> +# $NetBSD: Makefile,v 1.61 2026/05/14 13:15:13 ktnb Exp $
>> >>  
>> >> -DISTNAME=        isync-1.4.4
>> >> -PKGREVISION=     3
>> >> +DISTNAME=        isync-1.5.1
>> >>  CATEGORIES=      mail net
>> >>  MASTER_SITES=    ${MASTER_SITE_SOURCEFORGE:=isync/}
>> >>  
>> >>
>> >> Index: pkgsrc/mail/isync/distinfo
>> >> diff -u pkgsrc/mail/isync/distinfo:1.26 pkgsrc/mail/isync/distinfo:1.27
>> >> --- pkgsrc/mail/isync/distinfo:1.26       Sat May 13 08:49:27 2023
>> >> +++ pkgsrc/mail/isync/distinfo    Thu May 14 13:15:13 2026
>> >> @@ -1,10 +1,7 @@
>> >> -$NetBSD: distinfo,v 1.26 2023/05/13 08:49:27 ryoon Exp $
>> >> +$NetBSD: distinfo,v 1.27 2026/05/14 13:15:13 ktnb Exp $
>> >>  
>> >> -BLAKE2s (isync-1.4.4.tar.gz) = 50e873ff3d213b137b125ad0b8aca5774ee921867fb8c5481ffec5e5f45f51ca
>> >> -SHA512 (isync-1.4.4.tar.gz) = b769f474f2296764cabaae7e2b23e47c22714fca5919e9f1c916ed70b18c71c0bc9301fff0f64434f4f0ae28c9d16216e72556b48014ec94d1b7646de7183011
>> >> -Size (isync-1.4.4.tar.gz) = 340544 bytes
>> >> -SHA1 (patch-ae) = a3bdbdd05e32474bf76f8110561bdcea9b72b0c3
>> >> -SHA1 (patch-src_Makefile.in) = b989a7627dbb7c989dd26c3e20beeceb000a7a47
>> >> -SHA1 (patch-src_drv__imap.c) = cf838ac77a3c1e50311e2e00d78028c50689a0b3
>> >> -SHA1 (patch-src_socket.c) = 0397c9f41a4140d674761bd9fd1f57239120b6e1
>> >> -SHA1 (patch-src_socket.h) = d52684ebe95f085d11f8f30d442f06691b1d8315
>> >> +BLAKE2s (isync-1.5.1.tar.gz) = 4376d497aad83715fa952fbb333af8f686badf0109f4935ecb1aa908e6111ea6
>> >> +SHA512 (isync-1.5.1.tar.gz) = 3ccc37b9f902841e244acb16d574991062090770b5d8efb0079cee507f4352752e248f28cb6da63d21987f5c616e36d0dc6b8a7b20a89bcf805cd37429473d02
>> >> +Size (isync-1.5.1.tar.gz) = 324364 bytes
>> >> +SHA1 (patch-src_Makefile.in) = 7625c42f06bb3a9d5ce612593b8c8138f8b3603f
>> >> +SHA1 (patch-src_config.c) = 3c667a67dc8f5d460928af543b191353f1eda8d4
>> >>
>> >> Index: pkgsrc/mail/isync/patches/patch-src_Makefile.in
>> >> diff -u pkgsrc/mail/isync/patches/patch-src_Makefile.in:1.3 pkgsrc/mail/isync/patches/patch-src_Makefile.in:1.4
>> >> --- pkgsrc/mail/isync/patches/patch-src_Makefile.in:1.3   Wed Sep 19 13:08:14 2018
>> >> +++ pkgsrc/mail/isync/patches/patch-src_Makefile.in       Thu May 14 13:15:14 2026
>> >> @@ -1,15 +1,15 @@
>> >> -$NetBSD: patch-src_Makefile.in,v 1.3 2018/09/19 13:08:14 schmonz Exp $
>> >> +$NetBSD: patch-src_Makefile.in,v 1.4 2026/05/14 13:15:14 ktnb Exp $
>> >>  
>> >>  Install example config files in pkgsrc hierarchy.
>> >>  
>> >> ---- src/Makefile.in.orig 2017-10-01 08:46:50.000000000 +0000
>> >> +--- src/Makefile.in.orig 2026-05-13 18:06:05.736573667 +0000
>> >>  +++ src/Makefile.in
>> >> -@@ -359,7 +359,7 @@ mdconvert_LDADD = $(DB_LIBS)
>> >> - @with_mdconvert_TRUE@mdconvert_man = mdconvert.1
>> >> +@@ -581,7 +581,7 @@ tst_timers_SOURCES = tst_timers.c util.c
>> >> + tst_msg_cvt_CFLAGS = -DQPRINTF_BUFF=10000
>> >> + TESTS = $(check_PROGRAMS)
>> >>   tst_timers_SOURCES = tst_timers.c util.c
>> >> - man_MANS = mbsync.1 $(mdconvert_man)
>> >>  -exampledir = $(docdir)/examples
>> >>  +exampledir = $(datadir)/examples/isync
>> >>   example_DATA = mbsyncrc.sample
>> >> - EXTRA_DIST = drv_proxy_gen.pl run-tests.pl $(example_DATA) $(man_MANS)
>> >> + EXTRA_DIST = drv_proxy_gen.pl run-tests.pl $(example_DATA) $(in_man)
>> >>   CLEANFILES = drv_proxy.inc
>> >>
>> >> Added files:
>> >>
>> >> Index: pkgsrc/mail/isync/patches/patch-src_config.c
>> >> diff -u /dev/null pkgsrc/mail/isync/patches/patch-src_config.c:1.1
>> >> --- /dev/null     Thu May 14 13:15:14 2026
>> >> +++ pkgsrc/mail/isync/patches/patch-src_config.c  Thu May 14 13:15:14 2026
>> >> @@ -0,0 +1,15 @@
>> >> +$NetBSD: patch-src_config.c,v 1.1 2026/05/14 13:15:14 ktnb Exp $
>> >> +
>> >> +Avoid segfault when parsing configuration file under NetBSD.
>> >> +
>> >> +--- src/config.c.orig    2026-05-13 18:02:57.689819229 +0000
>> >> ++++ src/config.c
>> >> +@@ -433,7 +433,7 @@ load_config( const char *where )
>> >> + load_config( const char *where )
>> >> + {
>> >> +         conffile_t cfile;
>> >> +-        store_conf_t *store, **storeapp = &stores;
>> >> ++        store_conf_t *store = NULL, **storeapp = &stores;
>> >> +         channel_conf_t *channel, **channelapp = &channels;
>> >> +         group_conf_t *group, **groupapp = &groups;
>> >> +         string_list_t *chanlist, **chanlistapp;
>> >>
>> >
>> > -- 
>> > Ryo ONODERA // ryo%tetera.org@localhost
>> > PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3
>>
>> -- 
>> Ryo ONODERA // ryo%tetera.org@localhost
>> PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3
>>

-- 
Ryo ONODERA // ryo%tetera.org@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3