CVS commit: pkgsrc/comms/binkd

["David A. Holland" <dholland%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   dholland
Date:           Thu Feb 13 06:25:39 UTC 2025

Modified Files:
        pkgsrc/comms/binkd: Makefile distinfo
        pkgsrc/comms/binkd/patches: patch-aa

Log Message:
comms/binkd: tidy.

Clear PKG_DESTDIR_SUPPORT=destdir (not user-destdir). There is no
reason for this that I can find.

Clear MAKE_JOBS_SAFE=no. Other than a cosmetic problem with a
post-build message, the actual issue turns out to be a bmake bug.
(PR 59073) Add a couple small makefile adjustments to cope.

Clear BROKEN_ON_PLATFORM=${LP64PLATFORMS}. This seems to have been set
in 1999 and carried around uncritically ever since, across multiple
updates. It builds cleanly with -Wall on amd64, and while I can't test
(not sure anyone much can test this nowadays) that's usually a good
sign, and in 1999 it was described as "hopeless".

Tidy some pkglint.


To generate a diff of this commit:
cvs rdiff -u -r1.34 -r1.35 pkgsrc/comms/binkd/Makefile
cvs rdiff -u -r1.8 -r1.9 pkgsrc/comms/binkd/distinfo
cvs rdiff -u -r1.4 -r1.5 pkgsrc/comms/binkd/patches/patch-aa

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/comms/binkd/Makefile
diff -u pkgsrc/comms/binkd/Makefile:1.34 pkgsrc/comms/binkd/Makefile:1.35
--- pkgsrc/comms/binkd/Makefile:1.34    Sun Nov  3 12:04:12 2019
+++ pkgsrc/comms/binkd/Makefile Thu Feb 13 06:25:39 2025
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.34 2019/11/03 12:04:12 rillig Exp $
+# $NetBSD: Makefile,v 1.35 2025/02/13 06:25:39 dholland Exp $
 #
 
 DISTNAME=              binkd098
@@ -12,20 +12,14 @@ MAINTAINER=         pkgsrc-users%NetBSD.org@localhost
 #HOMEPAGE=             http://homepage.corbina.net/~maloff/binkd/
 COMMENT=               FidoNet-over-IP transport program utilizing BINKP protocol
 
-PKG_DESTDIR_SUPPORT=   destdir
-
-MAKE_JOBS_SAFE=                no
-
 WRKSRC=                        ${WRKDIR}/${PKGNAME_NOREV}
 GNU_CONFIGURE=         yes
 
-CONFIGURE_ARGS+=       --sysconfdir=${PKG_SYSCONFDIR:Q}
-INSTALL_MAKE_FLAGS=    ${MAKE_FLAGS} PREFIX=${DESTDIR:Q}${PREFIX:Q}
-
-BROKEN_ON_PLATFORM=    ${LP64PLATFORMS}
+CONFIGURE_ARGS+=       --sysconfdir=${PKG_SYSCONFDIR}
+INSTALL_MAKE_FLAGS=    ${MAKE_FLAGS} PREFIX=${DESTDIR}${PREFIX}
 
 post-extract:
-       @cd ${WRKSRC}/mkfls/unix && ${CHMOD} +x configure mkinstalldirs && \
-               ${CP} * ../../
+       (cd ${WRKSRC}/mkfls/unix && ${CHMOD} +x configure mkinstalldirs && \
+               ${CP} * ../../)
 
 .include "../../mk/bsd.pkg.mk"

Index: pkgsrc/comms/binkd/distinfo
diff -u pkgsrc/comms/binkd/distinfo:1.8 pkgsrc/comms/binkd/distinfo:1.9
--- pkgsrc/comms/binkd/distinfo:1.8     Tue Oct 26 10:05:58 2021
+++ pkgsrc/comms/binkd/distinfo Thu Feb 13 06:25:39 2025
@@ -1,6 +1,6 @@
-$NetBSD: distinfo,v 1.8 2021/10/26 10:05:58 nia Exp $
+$NetBSD: distinfo,v 1.9 2025/02/13 06:25:39 dholland Exp $
 
 BLAKE2s (binkd098.zip) = be68f45ae05f5c05c43724f986621c468c13ede58ef570a452510642bb349329
 SHA512 (binkd098.zip) = 901dfde092758a7f930f7b4af18ea8cc6a0f0d8fe37b88fb5b6095986aab981924ac89eefbc80a3582b28c88c7027146908ca295c1b9aec0a2d3d5f0efb03b72
 Size (binkd098.zip) = 306884 bytes
-SHA1 (patch-aa) = 88356eefd5f2ddad26474f57ce29e533c885b0dd
+SHA1 (patch-aa) = 830616f35968941b5abaf537ba9298b1714f50ab

Index: pkgsrc/comms/binkd/patches/patch-aa
diff -u pkgsrc/comms/binkd/patches/patch-aa:1.4 pkgsrc/comms/binkd/patches/patch-aa:1.5
--- pkgsrc/comms/binkd/patches/patch-aa:1.4     Mon Nov 29 00:58:09 2004
+++ pkgsrc/comms/binkd/patches/patch-aa Thu Feb 13 06:25:39 2025
@@ -1,7 +1,21 @@
-$NetBSD: patch-aa,v 1.4 2004/11/29 00:58:09 tv Exp $
+$NetBSD: patch-aa,v 1.5 2025/02/13 06:25:39 dholland Exp $
 
---- Makefile.in.orig   2004-11-28 19:45:33.000000000 -0500
+Configure for pkgsrc.
+Add a .WAIT so the post-build message comes out right.
+
+Work around a bmake problem (PR 59073) by using $< and $@ instead of $*.
+
+--- Makefile.in.orig   2025-02-13 05:40:19.401064526 +0000
 +++ Makefile.in
+@@ -16,7 +16,7 @@ DEFINES=$(AUTODEFS) -DHAVE_FORK -DUNIX -
+ CFLAGS=$(DEFINES) -Wall -Wno-char-subscripts @CFLAGS@
+ LIBS=$(AUTOLIBS)
+ 
+-all: compile banner
++all: compile .WAIT banner
+ 
+ compile: $(APPL)
+ 
 @@ -34,9 +34,8 @@ banner:
        @echo "        do not something criminal during the installation;   "
        @echo "     2. \`su' to root;                                       "
@@ -25,3 +39,12 @@ $NetBSD: patch-aa,v 1.4 2004/11/29 00:58
  
  clean:
        rm -f *.[bo] unix/*.[bo] ntlm/*.[bo] *.BAK *.core *.obj *.err 
+@@ -71,7 +70,7 @@ realclean: cleanall
+ 
+ .c.o:
+       @echo Compiling $*.c...
+-      @$(CC) -c $(CFLAGS) -o $*.o $*.c
++      @$(CC) -c $(CFLAGS) -o $@ $<
+ 
+ binkd.txt: binkd.8
+       @groff -Tascii -mman binkd.8 | perl -npe 's/.\010//g' >binkd.txt