pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

CVS commit: pkgsrc/math/py-scipy



Module Name:    pkgsrc
Committed By:   gdt
Date:           Tue Jan  7 16:54:12 UTC 2025

Modified Files:
        pkgsrc/math/py-scipy: Makefile

Log Message:
math/py-scpiy: c17 and add comments about compiler requirements

Declare that this needs c17, based on meson.build.  This has no effect
because it was marked for c++17 and both c17 and c++17 currently map
to gcc10.  Verified to still use gcc10 with the change.

Add comments about upstream requirements.

No PKGREVISION as this change should never have any effect on the
build.


To generate a diff of this commit:
cvs rdiff -u -r1.89 -r1.90 pkgsrc/math/py-scipy/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/math/py-scipy/Makefile
diff -u pkgsrc/math/py-scipy/Makefile:1.89 pkgsrc/math/py-scipy/Makefile:1.90
--- pkgsrc/math/py-scipy/Makefile:1.89  Tue Jan  7 15:58:01 2025
+++ pkgsrc/math/py-scipy/Makefile       Tue Jan  7 16:54:12 2025
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.89 2025/01/07 15:58:01 riastradh Exp $
+# $NetBSD: Makefile,v 1.90 2025/01/07 16:54:12 gdt Exp $
 
 DISTNAME=      scipy-1.15.0
 PKGNAME=       ${PYPKGPREFIX}-${DISTNAME}
@@ -23,10 +23,17 @@ TEST_DEPENDS+=      ${PYPKGPREFIX}-test-timeo
 TEST_DEPENDS+= ${PYPKGPREFIX}-test-xdist-[0-9]*:../../devel/py-test-xdist
 
 USE_CC_FEATURES=       c99
+USE_C_FEATURES=                c17
 USE_CXX_FEATURES=      c++17
 USE_LANGUAGES=         c c++ fortran
 USE_TOOLS+=            pkg-config
 MAKE_ENV+=             ATLAS=None
+# Upstream explicitly checks for 9; see meson.build.
+# gcc does not clearly document what version is needed for c17, but
+# our gcc.mk says 8 works and chooses 10.
+# gcc documents that 8 is suitable for c++17; our gcc.mk chooses 10.
+# Thus, this GCC_REQD is a no-op at the moment, but required for
+# correctness.
 GCC_REQD+=             9
 
 SUBST_CLASSES+=                f2py



Home | Main Index | Thread Index | Old Index