CVS commit: pkgsrc/graphics/tiff

["Greg Troxel" <gdt%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   gdt
Date:           Mon Feb 12 13:13:07 UTC 2024

Modified Files:
        pkgsrc/graphics/tiff: PLIST options.mk

Log Message:
graphics/tiff: Add default-off option to build unsupported tools

With "tiff-unsupported", also build tiff2pdf and tiff2ps.  These have
been withdrawn by upstream and this option is a temporary
accommodation for depending packages and workflows that (now
incorrectly, by definition) use these programs.  The only known such
depending package is hylafax.


To generate a diff of this commit:
cvs rdiff -u -r1.33 -r1.34 pkgsrc/graphics/tiff/PLIST
cvs rdiff -u -r1.2 -r1.3 pkgsrc/graphics/tiff/options.mk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/graphics/tiff/PLIST
diff -u pkgsrc/graphics/tiff/PLIST:1.33 pkgsrc/graphics/tiff/PLIST:1.34
--- pkgsrc/graphics/tiff/PLIST:1.33     Mon Oct 16 15:38:19 2023
+++ pkgsrc/graphics/tiff/PLIST  Mon Feb 12 13:13:07 2024
@@ -1,4 +1,6 @@
-@comment $NetBSD: PLIST,v 1.33 2023/10/16 15:38:19 gdt Exp $
+@comment $NetBSD: PLIST,v 1.34 2024/02/12 13:13:07 gdt Exp $
+${PLIST.unsupported}bin/tiff2pdf
+${PLIST.unsupported}bin/tiff2ps
 bin/tiffcp
 bin/tiffdump
 bin/tiffinfo

Index: pkgsrc/graphics/tiff/options.mk
diff -u pkgsrc/graphics/tiff/options.mk:1.2 pkgsrc/graphics/tiff/options.mk:1.3
--- pkgsrc/graphics/tiff/options.mk:1.2 Tue May 31 10:01:37 2005
+++ pkgsrc/graphics/tiff/options.mk     Mon Feb 12 13:13:07 2024
@@ -1,7 +1,7 @@
-# $NetBSD: options.mk,v 1.2 2005/05/31 10:01:37 dillo Exp $
+# $NetBSD: options.mk,v 1.3 2024/02/12 13:13:07 gdt Exp $
 
 PKG_OPTIONS_VAR=       PKG_OPTIONS.tiff
-PKG_SUPPORTED_OPTIONS= lzw
+PKG_SUPPORTED_OPTIONS= lzw tiff-unsupported
 PKG_SUGGESTED_OPTIONS= lzw
 
 .include "../../mk/bsd.options.mk"
@@ -14,3 +14,40 @@ CONFIGURE_ARGS+=     --enable-lzw
 .else
 CONFIGURE_ARGS+=       --disable-lzw
 .endif
+
+###
+### Unsupported tools
+###
+
+# Upstream has withdrawn many command-line tools.  Most have been
+# removed from the distfile.  tiff2ps and tiff2pdf are present but are
+# not built by default.  Upstream notes:
+#
+#   Starting with libtiff v4.6.0, the source code for most TIFF tools
+#   (except tiffinfo, tiffdump, tiffcp and tiffset) was discontinued,
+#   due to the lack of contributors able to address reported security
+#   issues. tiff2ps and tiff2pdf source code has been moved in a
+#   unsupported category, no longer built by default, but are still
+#   part of the the source distribution.  Other retired utilities are
+#   in a archive/ directory, only available in the libtiff git
+#   repository. Issues related to unsupported and archived tools will
+#   no longer be accepted in the libtiff bug tracker.
+#
+# Therefore, any depending package or workflow that uses tiff2ps or
+# tiffp2df is now buggy and should be fixed.  This option exists to
+# make it easier for people to accommodate those packages/workflows
+# until the problems are resolved.  Currently, the only known such
+# package is hylafax.
+#
+# This option is subject to removal if its presence causes any
+# trouble.
+
+PLIST_VARS+=           unsupported
+
+.if !empty(PKG_OPTIONS:Mtiff-unsupported)
+CONFIGURE_ARGS+=       --enable-tools-unsupported
+PLIST.unsupported=      yes
+
+WARNINGS+=     "Unsupported tools built:  Additional vulnerabilities are likely."
+WARNINGS+=     "Unsupported tools built:  Bugs may not be reported upstream."
+.endif