Re: CVS commit: pkgsrc/x11/qt4-libs

[Frédéric Fauberteau <triaxx%NetBSD.org@localhost>]

Le 15/09/2023 à 13:14, Tobias Nygren a écrit :
> On Wed, 13 Sep 2023 18:20:13 -0400
> Greg Troxel <gdt%lexort.com@localhost> wrote:
>
> > Frédéric Fauberteau <triaxx%netbsd.org@localhost> writes:
> >
> > > +NOT_FOR_PLATFORM=      Darwin-*-aarch64
> >
> > Please switch to BROKEN_ON.  The general expectation is that software is
> > portable, and there is no good reason why qt4 should be unavailable on
> > this platorm.
>
> The asm error is easy to fix with a patch, but qt4-libs won't work
> anyway on macOS newer than 13, even on x86_64, because of deprecated &
> removed Cocoa font functions. This is unlikely to ever be fixed and
> meets the requirement of NOT_FOR_PLATFORM+=Darwin-*-* as the platform
> did remove required things.
> But it should perhaps be qualified with an additional
> OPSYS_VERSION >= 130000 condition.
>
> -Tobias

Do you agree?
diff -r1.56 Makefile.common
22c22,24
< BROKEN_ON_PLATFORM=   Darwin-*-aarch64
---
> .if ${OPSYS_VERSION} >= 130000
> NOT_FOR_PLATFORM+=    Darwin-*-*
> .endif