Re: CVS commit: pkgsrc/mk

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Fri, Sep 29, 2023 at 12:28:23AM +0200, Roland Illig wrote:
> Am 28.09.2023 um 23:08 schrieb Joerg Sonnenberger:
> > On Thu, Sep 28, 2023 at 06:40:53PM +0000, Roland Illig wrote:
> >> Log Message:
> >> mk/curses: don't search for makefiles outside the pkgsrc directory
> >
> > But this is not how path lookup in make works?
> 
> It is.
> 
> Make first tries the path relative to the including file, as documented
> in the manual page. In usr.bin/make/parse.c, that's implemented in
> IncludeFile and FindFileRelative.
> 
> If that fails, it tries the path relative to ${.CURDIR} as a fallback.
> This fallback is not documented in the manual page, though.

That's not what the documentation says. It's also not what all of
pkgsrc/mk expects. 

> 
> I verified this by adding this line at the top of mk/bsd.pkg.mk:
> > .sinclude "../../does-not-exist.mk"
> 
> When I ran 'make -v MAKE' in a package directory, make first searched
> for '../../../does-not-exist.mk' (outside pkgsrc), falling back to
> '../../does-not-exist.mk'.
> 
> Same for bmake from pkgsrc.

...sounds more like someone created a regression.

Joerg